Skip to content

{AKS} Fix several tests#8975

Merged
yanzhudd merged 3 commits intoAzure:mainfrom
FumingZhang:fuming/aks-fix-0716
Jul 17, 2025
Merged

{AKS} Fix several tests#8975
yanzhudd merged 3 commits intoAzure:mainfrom
FumingZhang:fuming/aks-fix-0716

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang commented Jul 16, 2025 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • {AKS} Fix several tests failure caused by dependency bump.
  • test_aks_approuting_update and test_aks_approuting_update_with_monitoring_addon_enabled are marked as live only, the corresponding recording files are useless so removing them.
  • update command az aks namespace to use client (SDK) initiated from cli-extensions/aks-preview

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 16, 2025 07:41
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jul 16, 2025 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jul 16, 2025

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copilot AI reviewed Jul 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several tests in the AKS extension that were failing due to dependency bumps. The primary change is updating Azure KeyVault API version references in test recordings to ensure compatibility with newer dependencies.

  • Updates Azure KeyVault API version from 2023-02-01 to 2024-11-01 in test recordings
  • Maintains existing test functionality while ensuring compatibility with updated dependencies

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jul 16, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 16, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 16, 2025 •
edited
Loading

Hi @FumingZhang

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 18.0.0b19 in src/aks-preview/setup.py

Notes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 16, 2025

@FumingZhang FumingZhang mentioned this pull request Jul 17, 2025
Merged
4 tasks
@yanzhudd yanzhudd merged commit 00aa9cc into Azure:main Jul 17, 2025
24 checks passed
@FumingZhang FumingZhang deleted the fuming/aks-fix-0716 branch September 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@yanzhudd yanzhudd yanzhudd approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@zhoxing-ms zhoxing-ms

@yanzhudd yanzhudd

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Milestone

August 2025 (2025-08-05)

Development

Successfully merging this pull request may close these issues.

5 participants

@FumingZhang @yonzhan @yanzhudd @zhoxing-ms